Add support for Falcon framework requests #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rhcarvalho! Sorry it's taken so long to respond here, this one got a little lost... Assuming you still want this, could you rebase it against master, and add a test? We'll be happy to merge it with a test. |
|
Hi @brianr sorry for the delay. I'm not needing this anymore. Closing the PR. Thanks. |
|
OK - no problem, thanks for clearing it out! |
|
Hi, we are currently using rollbar with falcon in production and were wondering if this PR could be looked at again. We would greatly appreciate the additional request info from falcon without having to wrap the request or fork the library. |
|
I'll update the PR. |
|
Thanks Ivan Gomez for getting some traction on this. |
rhcarvalho
force-pushed
the
falcon-framework
branch
from
84b04ca
to
2b58f41
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.